snarkOS icon indicating copy to clipboard operation
snarkOS copied to clipboard

[Bug] Most recent `curl-sys` crate update causes SnarkOS build to fail due to SnarkOS MSRV being at `v1.76.0`

Open iamalwaysuncomfortable opened this issue 1 year ago • 1 comments

🐛 Bug Report

The curl-sys library version was recently bumped to 0.4.76 which updated the Rust MSRV in that crate to 1.80.0. This currently causes SnarkOS to fail to build using cargo build or cargo install to fail.

This is resolved if the MSRV in SnarkOS is updated.

Steps to Reproduce

  1. Navigate to the SnarkOS main directory
  2. Execute cargo build or cargo install --path .
  3. The build fails with the error:
error: unsupported output in build script of `curl-sys v0.4.76+curl-8.10.1`: `cargo::rustc-check-cfg=cfg(libcurl_vendored,link_libnghttp2,link_libz,link_openssl,)`
Found a `cargo::key=value` build directive which is reserved for future use.
Either change the directive to `cargo:key=value` syntax (note the single `:`) or upgrade your version of Rust.
See https://doc.rust-lang.org/cargo/reference/build-scripts.html#outputs-of-the-build-script for more information about build script outputs.

Potential Fixes

  • Update the MSRV in SnarkOS/SnarkVM to Rust v1.80.0 or forcing usage of Rust >1.80.0 fixes the issue. As of this bug report, the full consequences of updating the Rust MSRV in SnarkOS haven't been weighed, but it likely should be updated as more libraries may start to fail in the future.

iamalwaysuncomfortable avatar Sep 23 '24 23:09 iamalwaysuncomfortable

@iamalwaysuncomfortable could you please confirm this is fixed with the merging of #3413?

zosorock avatar Oct 17 '24 18:10 zosorock

Should be resolved with #3413

raychu86 avatar Nov 19 '24 23:11 raychu86