snarkOS icon indicating copy to clipboard operation
snarkOS copied to clipboard

Rename RPC args to HTTP, use those values for the warp server

Open ljedrz opened this issue 3 years ago • 3 comments

This fixes the initial panic if port 80 is in use (which is extremely likely), adjusts the settings to the current server setup and allows the user to specify the address or disable it.

Closes https://github.com/AleoHQ/snarkOS/issues/1875.

ljedrz avatar Aug 19 '22 08:08 ljedrz

Rebased and applied comments.

ljedrz avatar Aug 26 '22 07:08 ljedrz

Binding to all IP addresses by default will generally cause confusion. Does this patch also attempt to bind to port 80 by default? This requires running as root, and IMO, that's a security problem.

ETA on this? This issue affects everyone in the community on first-run experience.

damons avatar Sep 25 '22 20:09 damons

Binding to all IP addresses by default will generally cause confusion.

I'd also prefer it to be set to localhost instead, it should work fine as long as the requests are local.

Does this patch also attempt to bind to port 80 by default?

This patch doesn't change that value, but I would also recommend it to be set to something different.

ljedrz avatar Sep 25 '22 20:09 ljedrz

Closing, as it's no longer applicable.

ljedrz avatar Dec 14 '22 14:12 ljedrz