snarkOS icon indicating copy to clipboard operation
snarkOS copied to clipboard

Test compilation under different feature flags on CI

Open niklaslong opened this issue 3 years ago • 2 comments

As illustrated by #1685, our CI can currently miss breakage in feature-gated logic. We should be testing the succesful compilation under all feature flags on CI.

We could use cargo hack, though we'd need to adjust some of the settings as compiling without the defaults will break, as will the metrics crate with all features enabled (mutually exclusive features).

niklaslong avatar Mar 12 '22 20:03 niklaslong

@niklaslong @ljedrz Is this still relevant?

raychu86 avatar Nov 19 '24 21:11 raychu86

I don't think it's anything pressing, as I don't recall this being an issue in a long time, we're not frequently changing features, and we have CI runs for the combinations of features that we want to support. That being said, if we do run into something like that, we should remember tools like cargo hack.

ljedrz avatar Nov 20 '24 09:11 ljedrz

Closing this, but putting cargo hack on the list of repo maintenance tools to look into

vicsn avatar Jul 31 '25 11:07 vicsn