leo
leo copied to clipboard
feat: hide inputed private key when import an account
Motivation
close #10060
Support to hide the inputed private key when we run leo account import
. And the private key in output will show discreetly, see another pr 10018
This issue does not qualify for a contributor badge because a bot is suspected. If you are not a bot, please reach out to us directly and provide proof.
This issue does not qualify for a contributor badge because a bot is suspected. If you are not a bot, please reach out to us directly and provide proof.
This doesn't for the contributor badge, but add a new feature to leo, how to contact you sir?
@d0cd Sincerely thanks.
Codecov Report
Attention: 13 lines
in your changes are missing coverage. Please review.
Comparison is base (
a2e3155
) 75.65% compared to head (9297c44
) 75.47%.
Files | Patch % | Lines |
---|---|---|
leo/cli/commands/account.rs | 0.00% | 9 Missing :warning: |
errors/src/errors/cli/cli_errors.rs | 0.00% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## testnet3 #10062 +/- ##
============================================
- Coverage 75.65% 75.47% -0.19%
============================================
Files 203 203
Lines 7049 7054 +5
Branches 7049 7054 +5
============================================
- Hits 5333 5324 -9
- Misses 1716 1730 +14
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey there @Halimao, so very sorry for closing your issue.
We're currently battling a bot army of contributor spam and, unfortunately, the script I wrote had a random bug that included your issue in it. Thank you for working with us and for your patience!
Also, thank you @d0cd for the save! π
Hey there @Halimao, so very sorry for closing your issue.
We're currently battling a bot army of contributor spam and, unfortunately, the script I wrote had a random bug that included your issue in it. Thank you for working with us and for your patience!
Also, thank you @d0cd for the save! π
It's fineπ. BTW, the issue #10060 is still closed now, could u plz help me to reopen it, thanks
@aharshbe @d0cd Hi, looking forward for your review~
thank u
thank u
For what?
Thank you for the instructions. I followed the instructions
@aharshbe Hi sir, could you please help me review this pr, thanks π
Could we incorporate the changes from #10018 and use the
--discreet
flag for the password prompt?
@d0cd Hi sir, Did you mean that incorporate the changes from #10018 to this pr, then close pr 10018?
And add --discreet
flag for using password prompt
to input the private key?
IMO these two pr are different, maybe we can merge #10018 first, and I will merge the testnet3
branch's new changes to this pr
@d0cd Hi sir, suggestion changes have been addressed, looking forward to your review again
@d0cd Hi sir, can we get this merge then?
@Halimao would mind fixing the build and conflict? We'll push the PR through afterwords
@Halimao would mind fixing the build and conflict? We'll push the PR through afterwords
Addressed~