leo icon indicating copy to clipboard operation
leo copied to clipboard

feat: hide inputed private key when import an account

Open Halimao opened this issue 1 year ago β€’ 16 comments

Motivation

close #10060

Support to hide the inputed private key when we run leo account import. And the private key in output will show discreetly, see another pr 10018

image

Halimao avatar Nov 28 '23 11:11 Halimao

This issue does not qualify for a contributor badge because a bot is suspected. If you are not a bot, please reach out to us directly and provide proof.

aharshbe avatar Nov 28 '23 21:11 aharshbe

This issue does not qualify for a contributor badge because a bot is suspected. If you are not a bot, please reach out to us directly and provide proof.

This doesn't for the contributor badge, but add a new feature to leo, how to contact you sir?

Halimao avatar Nov 28 '23 23:11 Halimao

@d0cd Sincerely thanks.

Halimao avatar Nov 29 '23 00:11 Halimao

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (a2e3155) 75.65% compared to head (9297c44) 75.47%.

Files Patch % Lines
leo/cli/commands/account.rs 0.00% 9 Missing :warning:
errors/src/errors/cli/cli_errors.rs 0.00% 4 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##           testnet3   #10062      +/-   ##
============================================
- Coverage     75.65%   75.47%   -0.19%     
============================================
  Files           203      203              
  Lines          7049     7054       +5     
  Branches       7049     7054       +5     
============================================
- Hits           5333     5324       -9     
- Misses         1716     1730      +14     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 29 '23 00:11 codecov[bot]

Hey there @Halimao, so very sorry for closing your issue.

We're currently battling a bot army of contributor spam and, unfortunately, the script I wrote had a random bug that included your issue in it. Thank you for working with us and for your patience!

Also, thank you @d0cd for the save! πŸ™‚

aharshbe avatar Nov 29 '23 06:11 aharshbe

Hey there @Halimao, so very sorry for closing your issue.

We're currently battling a bot army of contributor spam and, unfortunately, the script I wrote had a random bug that included your issue in it. Thank you for working with us and for your patience!

Also, thank you @d0cd for the save! πŸ™‚

It's fineπŸ˜€. BTW, the issue #10060 is still closed now, could u plz help me to reopen it, thanks

Halimao avatar Nov 29 '23 06:11 Halimao

@aharshbe @d0cd Hi, looking forward for your review~

Halimao avatar Dec 03 '23 03:12 Halimao

thank u

bebbb1990 avatar Dec 09 '23 06:12 bebbb1990

thank u

For what?

Halimao avatar Dec 09 '23 06:12 Halimao

Thank you for the instructions. I followed the instructions

bebbb1990 avatar Dec 09 '23 06:12 bebbb1990

@aharshbe Hi sir, could you please help me review this pr, thanks πŸ˜€

Halimao avatar Jan 05 '24 03:01 Halimao

Could we incorporate the changes from #10018 and use the --discreet flag for the password prompt?

@d0cd Hi sir, Did you mean that incorporate the changes from #10018 to this pr, then close pr 10018?

And add --discreet flag for using password prompt to input the private key?

IMO these two pr are different, maybe we can merge #10018 first, and I will merge the testnet3 branch's new changes to this pr

Halimao avatar Jan 16 '24 04:01 Halimao

@d0cd Hi sir, suggestion changes have been addressed, looking forward to your review again

Halimao avatar Jan 18 '24 02:01 Halimao

@d0cd Hi sir, can we get this merge then?

Halimao avatar Feb 01 '24 09:02 Halimao

@Halimao would mind fixing the build and conflict? We'll push the PR through afterwords

d0cd avatar Feb 12 '24 04:02 d0cd

@Halimao would mind fixing the build and conflict? We'll push the PR through afterwords

Addressed~

Halimao avatar Feb 12 '24 08:02 Halimao