Convert from minidom to roxml
all tests pass, and generate the same json from test_xml_files examples
closes #21
Hi @AlecTroemel. I am waiting on this too :-)
There are some parsing differences between these 2 crates. I wonder if it may impact existing implementations. For example, it handles whitespace differently: https://github.com/RazrFalcon/roxmltree/blob/master/docs/parsing.md#whitespaces
Did we forget to bump the version?
@rimutaka hmm.. that could explain why i had to change the Null value config here https://github.com/AlecTroemel/quickxml_to_serde/pull/22/files#diff-a0262fea108af44a98cc49e5eb72641963dd816513f2d0a22eb738fcfed55ebeR353 to get tests passing.
I'll take another look there, ideally we'd be able to pass tests without making any changes to them
aha, I think i've fixed the change, tests now pass with no changes from master branch!
this MR does make the name of this repo incorrect.. Not sure the best way to handle that :thinking:
I think the version should probably be bumped to 1.0 since the public api is returning roxmltree::Error errors now.
@AlecTroemel just a note; this branch won't compile with the json_types feature enabled.
I also have two changes in behavior while running this branch across my local test suite (after propagating path to convert_text):
- non-declared namespaces now error with
UnknownNamespacewhile parsing - whitespace before the initial xml tag errors with
ParserErroron the first<character in this example
let xml = r#"
<?xml version="1.0" encoding="UTF-8"?>
"#;
another behavioral change I have noticed though I don't see immediately why; is that when using types the it used to come out as @namespace:type but now only generates @type.
Any updates on that?