quickxml_to_serde icon indicating copy to clipboard operation
quickxml_to_serde copied to clipboard

Convert from minidom to roxml

Open AlecTroemel opened this issue 2 years ago • 9 comments

all tests pass, and generate the same json from test_xml_files examples

closes #21

AlecTroemel avatar Mar 24 '23 16:03 AlecTroemel

Hi @AlecTroemel. I am waiting on this too :-)

Vagelis-Prokopiou avatar Mar 27 '23 06:03 Vagelis-Prokopiou

There are some parsing differences between these 2 crates. I wonder if it may impact existing implementations. For example, it handles whitespace differently: https://github.com/RazrFalcon/roxmltree/blob/master/docs/parsing.md#whitespaces

Did we forget to bump the version?

rimutaka avatar Mar 27 '23 23:03 rimutaka

@rimutaka hmm.. that could explain why i had to change the Null value config here https://github.com/AlecTroemel/quickxml_to_serde/pull/22/files#diff-a0262fea108af44a98cc49e5eb72641963dd816513f2d0a22eb738fcfed55ebeR353 to get tests passing.

I'll take another look there, ideally we'd be able to pass tests without making any changes to them

AlecTroemel avatar Mar 28 '23 15:03 AlecTroemel

aha, I think i've fixed the change, tests now pass with no changes from master branch!

AlecTroemel avatar Mar 28 '23 15:03 AlecTroemel

this MR does make the name of this repo incorrect.. Not sure the best way to handle that :thinking:

AlecTroemel avatar Mar 28 '23 15:03 AlecTroemel

I think the version should probably be bumped to 1.0 since the public api is returning roxmltree::Error errors now.

Ryan-Knepp avatar Mar 30 '23 15:03 Ryan-Knepp

@AlecTroemel just a note; this branch won't compile with the json_types feature enabled.

I also have two changes in behavior while running this branch across my local test suite (after propagating path to convert_text):

  • non-declared namespaces now error with UnknownNamespace while parsing
  • whitespace before the initial xml tag errors with ParserError on the first < character in this example
        let xml = r#"
            <?xml version="1.0" encoding="UTF-8"?>
            "#;

cjschneider2 avatar Oct 18 '23 11:10 cjschneider2

another behavioral change I have noticed though I don't see immediately why; is that when using types the it used to come out as @namespace:type but now only generates @type.

cjschneider2 avatar Oct 19 '23 10:10 cjschneider2

Any updates on that?

Keats avatar May 27 '24 18:05 Keats