survey icon indicating copy to clipboard operation
survey copied to clipboard

Allow hiding password length

Open szh opened this issue 2 years ago • 5 comments

Addresses comments to #386

This PR allows you to set the HideCharacter to a space which will be interpreted by the RuneReader to mean that the user input should not be echoed and that it shouldn't print a "mask" either.

szh avatar Apr 03 '23 19:04 szh

This looks good - mind adding a test case to this file?

AlecAivazis avatar May 04 '23 16:05 AlecAivazis

This looks good - mind adding a test case to this file?

I don't see how to add a test case there since the prompt is the same. I think this would require some refactoring. Do you want me to attempt?

szh avatar May 04 '23 17:05 szh

@AlecAivazis can we get this moving?

szh avatar Jun 23 '23 15:06 szh

Yea feel free to refactor the tests to verify this behavior

AlecAivazis avatar Jun 23 '23 17:06 AlecAivazis

Whoops! Wrong button 😅

AlecAivazis avatar Jun 23 '23 17:06 AlecAivazis