ExpandableCardView icon indicating copy to clipboard operation
ExpandableCardView copied to clipboard

Published 20 hours ago • verified publisher icon AleSpero

Dark theme

Open ShanuDey opened this issue 5 years ago • 8 comments

When it switched to the new dark theme mode then the title of the card view is not adapting the appropriate material theme.

ShanuDey avatar Feb 04 '20 17:02 ShanuDey

When it switched to the new dark theme mode then the title of the card view is not adapting the appropriate material theme.

This library was updated over a year ago. Not sure if it's still being maintained. I forked this project and added this already.

Stjin avatar Feb 04 '20 18:02 Stjin

I tried your fork, but it has an error.

ERROR: Failed to resolve: com.github.Stjinchan:ExpandableCardView:1.1.4 Show in Project Structure dialog Affected Modules: app

Do u know any solution to fix this? @

ShanuDey avatar Feb 06 '20 07:02 ShanuDey

I tried your fork, but it has an error.

ERROR: Failed to resolve: com.github.Stjinchan:ExpandableCardView:1.1.4 Show in Project Structure dialog Affected Modules: app

Do u know any solution to fix this? @

Please add Jitpack to your build.gradle

Stjin avatar Feb 06 '20 07:02 Stjin

Hello everyone,

The library unfortunately is not actively mantained due to time issues. However, @Stjinchan if you are willing to fix this issue feel free to open a PR and i'll review it and eventually merge it into the main branch.

Kind regards :)

Alessandro

AleSpero avatar Feb 06 '20 08:02 AleSpero

Hello everyone,

The library unfortunately is not actively mantained due to time issues. However, @Stjinchan if you are willing to fix this issue feel free to open a PR and i'll review it and eventually merge it into the main branch.

Kind regards :)

Alessandro

Fixed already with some other issues. I'll PR these later this week. Currently trying to fix 1 more annoying bug I can't seem to fix :P

Stjin avatar Feb 06 '20 08:02 Stjin

@Stjinchan The expanding arrow color should change according to the theme. In the dark theme, it gets camouflaged.

ShanuDey avatar Feb 07 '20 03:02 ShanuDey

@Stjinchan The expanding arrow color should change according to the theme. In the dark theme, it gets camouflaged.

Please create an issue on my fork as I am mainly maintaining that one. I'll fix it tonight.

Stjin avatar Feb 07 '20 09:02 Stjin

When it switched to the new dark theme mode then the title of the card view is not adapting the appropriate material theme.

This library was updated over a year ago. Not sure if it's still being maintained. I forked this project and added this already.

Thank you Sir!

bytss avatar Jan 21 '22 04:01 bytss