liquidart icon indicating copy to clipboard operation
liquidart copied to clipboard

Null check operator used on a null value using in Router constructor, RouteNode constructor

Open ifuterman opened this issue 4 years ago • 3 comments

Constructor has notation: Router({String? basePath, Future notFoundHandler(Request request)?}) That means that the notFoundHandler value can be null. In aexamples, you use default parameters (null). But in constructor you use : _unmatchedController = notFoundHandler!

ifuterman avatar Apr 22 '21 16:04 ifuterman

RouteNode(List<RouteSpecification?> specs, {int depth = 0, RegExp? matcher}) { patternMatcher = matcher!; But you use it with null value in Router.didAddToChannel

ifuterman avatar Apr 22 '21 17:04 ifuterman

@ifuterman

Thanks for reporting this. I have already encountered this issue on my end. The entire Aqueduct (Liquidart was supposed to be the revival of Aqueduct) package was a nightmare to migrate to Null Safety with more than 6000 errors showing up during migration. It took me 4 consecutive days of work to resolve all of those. I rescheduled all of my other projects to accommodate this. I hoped that the migration to null safety will prepare the package for publishing. Little did I know that the entire Aqueduct codebase is absolutely messed up. I have been trying to solve some list-related errors for the past 2 days, only to find out that those errors have been present in the project for more than 8 months. And I am all alone working in this project which makes it even worse.

aldrinmathew avatar Apr 22 '21 17:04 aldrinmathew

@ifuterman

Please read Issue 7: Liquidart will be rewritten from scratch to understand the status of this issue and the Liquidart project.

aldrinmathew avatar Apr 22 '21 17:04 aldrinmathew