Fix filtering Attachments by only or except param

[tvdeyen]

What is this pull request for?

This seems to be broken for some time now.

Checklist

• [x] I have followed Pull Request guidelines
• [x] I have added a detailed description into each commit message
• [x] I have added tests to cover this change

[codecov[bot]]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 97.20%. Comparing base (3160be9) to head (7f71821). :warning: Report is 10 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3500   +/-   ##
=======================================
  Coverage   97.19%   97.20%           
=======================================
  Files         287      287           
  Lines        7559     7586   +27     
=======================================
+ Hits         7347     7374   +27     
  Misses        212      212           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mamhoff]

This looks and feels really good! One minor nit: The filters on the overlay accessed from elements look like they can be edited (the tags have x marks) - but clicking them does nothing (sensibly). Also, when you happen to try adding a video in an element, but have no video files, the filter select appears empty. Both of these are super minor, and I'm approving anyways.

[tvdeyen]

This looks and feels really good! One minor nit: The filters on the overlay accessed from elements look like they can be edited (the tags have x marks) - but clicking them does nothing (sensibly).

Interest. Not happening to me. I am still able to remove and add types, as long as they are in the allowed types.

Also, when you happen to try adding a video in an element, but have no video files, the filter select appears empty. Both of these are super minor, and I'm approving anyways.

Hmm. Maybe related to your above issue. Not sure what to do about that. We do not want to maintain a list of all available mine types in the world, right?

Let's use this for now and fix if they are real world issues. Thanks for taking the time to review this locally.

[alchemycms-bot[bot]]

💔 All backports failed

Status	Branch	Result
❌	8.0-stable	Backport failed because of merge conflicts You might need to backport the following PRs to 8.0-stable: - Remove dialog sitemap css code - Fix sitemap highlight color in dark mode - Make create element dialog wider (#3445) - Fix element icon hover for elements with warning (#3444) - Fix select2 close icon visibility (#3443)

Manual backport

To create the backport manually run:

backport --pr 3500

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

[tvdeyen]

💚 All backports created successfully

Status	Branch	Result
✅	8.0-stable

Questions ?

Please refer to the Backport tool documentation