Flips icon indicating copy to clipboard operation
Flips copied to clipboard

Add checksum skip checkbox to settings window

Open animeavi opened this issue 2 years ago • 4 comments

Fixes #49

image image

animeavi avatar Nov 16 '22 08:11 animeavi

Thanks for this. Makes patching expansions a lot less painful.

subvod avatar Mar 25 '23 01:03 subvod

@Alcaro is there anything specifically that's blocking this PR?

Miepee avatar May 30 '24 17:05 Miepee

As mentioned in #49, I'm not a huge fan of this approach, so I don't want to merge it. But it's properly written, and it adds a feature people ask for, so I don't want to reject it just because I'm a cranky lil shit.

That doesn't leave a whole lot of options.

Alcaro avatar May 30 '24 17:05 Alcaro

If the point is to protect noobs from shooting themselves in the foot, the GUI label could be changed DANGEROUS: Ignore checksum when patching and/or pop up a dialog box asking the user if they really want to disable them and explain them briefly the consequences.

Miepee avatar May 30 '24 18:05 Miepee