welle.io icon indicating copy to clipboard operation
welle.io copied to clipboard

Document to open PR only for the next branch

Open AlbrechtL opened this issue 3 years ago • 3 comments

Details are here https://github.com/AlbrechtL/welle.io/pull/622#issuecomment-767106907

AlbrechtL avatar Jan 26 '21 14:01 AlbrechtL

But you don't want to set the next branch to default, right?

andimik avatar Jan 26 '21 14:01 andimik

Recommendation: You can add PR templates to your repo, allowing you to predefine the text people see, including checkboxes like:

  • [ ] I've made sure code is properly indented / formatted
  • [ ] If this is anything but a bugfix that specifically targets a released version, I'm doing a PR against next, not any other branch.
  • [ ] My hovercraft is full of eels

marcusmueller avatar Mar 03 '21 19:03 marcusmueller

Thanks for the hint! Now it is just a matter of doing.

But you don't want to set the next branch to default, right?

Yes, because the next branch is the development branch and sometimes the code is broken.

AlbrechtL avatar May 22 '21 12:05 AlbrechtL