welle.io icon indicating copy to clipboard operation
welle.io copied to clipboard

[macOS] ringbuffer is using deprecated API on macOS 10.12

Open mattes-bru opened this issue 5 years ago • 1 comments

when I build welle.io on macOS 10.12 I get a multiple warnings like this:

../../../welle.io/src/various/ringbuffer.h:348:13: warning: 'OSMemoryBarrier' is deprecated: first deprecated in macOS 10.12 - Use std::atomic_thread_fence() from <atomic> instead [-Wdeprecated-declarations]
            PaUtil_FullMemoryBarrier ();
            ^
../../../welle.io/src/various/ringbuffer.h:89:40: note: expanded from macro 'PaUtil_FullMemoryBarrier'
#   define PaUtil_FullMemoryBarrier()  OSMemoryBarrier()
                                       ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/libkern/OSAtomicDeprecated.h:749:9: note: 'OSMemoryBarrier' has been explicitly marked deprecated here

mattes-bru avatar Jan 07 '19 22:01 mattes-bru

We have in mind to replace the ring buffer implementation (https://github.com/AlbrechtL/welle.io/issues/247#issuecomment-440814615). But this is not a high prior task because the existing implementation is working.

It would be very nice if someone can send a pull request with an alternative implementation.

AlbrechtL avatar Jan 08 '19 17:01 AlbrechtL