Albert Wolszon

Results 61 comments of Albert Wolszon

I wanted to +1 the part regarding the *early-return, else promote variable type*. I'm not a fan of the entirety of the `guard` clause. I just want concise early returns...

@davidhicks980 making the `MenuController` _final_ just broke our code, we were extending the `MenuController` to add some animation functionality. Was this breaking change really intended?

@dariuszseweryn hey! Do you plan on releasing a version with that addition soon? :)

@Levi-Lesches hey, I understand that I can calculate date to use in `scheduledDate` by adding interval to current time, so I can use `zonedSchedule`. But I can't use `zonedSchedule`, because...

The notification just does not appear. That's how iOS is I believe. I may create a simple demo for you tomorrow or later if you want

cc @andrewkolos, as I'm aware you're the one behind the transformers (thanks for the work on them!)

With this addition, the asset transformation took 10 minutes (whole `flutter run` took 680,563ms). And my CPU usage was at 60%, and not 100%. Fans didn't even turn on :)...

Currently the `whitespace.dart` file removes the `&nbsp` treating it as a whitespace, and then removes the now-empty `p` element: https://github.com/Sub6Resources/flutter_html/blob/79ec194fa6690e5caba58f5eca04e6748394bb6b/lib/src/processing/whitespace.dart#L16-L17 That's not consistent with how browsers treat such paragraphs. An...

And same with the focus tree - #5326