FastShopping icon indicating copy to clipboard operation
FastShopping copied to clipboard

Attempt at implementing the addition requested in issue #99.

Open Lovasz-Akos opened this issue 3 years ago • 6 comments

Couldn't test full release build since I don't have the keystore for it (hopefully when this pr opens github actions run to see if it builds?)

#99 wanted the ability to delete all of the done items in multi list mode aswell, since right now this feature is only availible on single list mode.

Lovasz-Akos avatar Jul 24 '22 17:07 Lovasz-Akos

Codecov Report

Base: 97.32% // Head: 97.32% // No change to project coverage :thumbsup:

Coverage data is based on head (207f503) compared to base (c50abc2). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files           6        6           
  Lines         187      187           
=======================================
  Hits          182      182           
  Misses          5        5           
Flag Coverage Δ
bloc 97.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 24 '22 17:07 codecov[bot]

some extra info on kotlin and gradle version updates:

Lovasz-Akos avatar Jul 24 '22 17:07 Lovasz-Akos

using gradle 4.1.1 failed with the following message, so downgraded to 4.1.0, a fix suggested here

Running Gradle task 'assembleDebug'...
Exception: Unsupported Android Plugin version: 4.1.1.

Lovasz-Akos avatar Jul 24 '22 17:07 Lovasz-Akos

targeted sdk had to be raised to fix a dependency conflict that needs a higher sdk. fails with the following

Execution failed for task ':app:checkFossDebugAarMetadata'.
> Multiple task action failures occurred:
   > A failure occurred while executing com.android.build.gradle.internal.tasks.CheckAarMetadataWorkAction
      > The minCompileSdk (31) specified in a
        dependency's AAR metadata (META-INF/com/android/build/gradle/aar-metadata.properties)
        is greater than this module's compileSdkVersion (android-29).
        Dependency: androidx.window:window-java:1.0.0-beta04.
        AAR metadata file: C:\Users\akos4\.gradle\caches\transforms-2\files-2.1\68fac80a543730b86add500257caced4\jetified-window-java-1.0.0-beta04\META-INF\com\android\build\gradle\[aar-metadata.properties](http://aar-metadata.properties/).

Lovasz-Akos avatar Jul 24 '22 18:07 Lovasz-Akos

flutter version had to be raised because of the following build fail

BUILD FAILED in 19s
Running Gradle task 'assembleDebug'...                             20.3s

┌─ Flutter Fix ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ [!] Your project requires a newer version of the Kotlin Gradle plugin.                                                                          │
│ Find the latest version on https://kotlinlang.org/docs/gradle.html#plugin-and-versions, then update D:\Repos\FastShopping\android\build.gradle: │
│ ext.kotlin_version = '<latest-version>'                                                                                                         │
└─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
Exception: Gradle task assembleDebug failed with exit code 1

Lovasz-Akos avatar Jul 24 '22 18:07 Lovasz-Akos

also the logo turned orange and I have no idea why

Lovasz-Akos avatar Jul 24 '22 18:07 Lovasz-Akos

well this app is sadly dead, imma make my own lol

Lovasz-Akos avatar Jun 06 '23 07:06 Lovasz-Akos