egmde icon indicating copy to clipboard operation
egmde copied to clipboard

Fixed issue of SIGSEGV (branch Article-2)

Open KillbugChance opened this issue 1 year ago • 3 comments

…(branch Article-2) Removed duplicate wl_display_roundtrip() call to fix the SEGSEGV issue.

KillbugChance avatar Jan 02 '25 18:01 KillbugChance

I'm curious that this would fix a SEGSEGV. A duplicate wl_display_roundtrip() might be needed for synchronization of a follow-up request. But, if it is not needed, then the second wl_display_roundtrip() should be idempotent.

AlanGriffiths avatar Jan 16 '25 14:01 AlanGriffiths

I'm curious that this would fix a SEGSEGV. A duplicate wl_display_roundtrip() might be needed for synchronization of a follow-up request. But, if it is not needed, then the second wl_display_roundtrip() should be idempotent.

Sorry for the confusing. Please ignore or drop this PR. I am a beginner about Github and without confirming too much due to my poor knowledge of libamir. Actually, I did that - remove one wl_display_roundtrip(), and found it built and worked well. Just so. (still learning it.)

KillbugChance avatar Jan 17 '25 08:01 KillbugChance

@KillbugChance you're not to blame: I just don't want to land without understanding the why and hoped you had some insight.

It may take some time before I get to this as it doesn't look simple and I switched focus to Miriway years ago.

AlanGriffiths avatar Jan 17 '25 11:01 AlanGriffiths