Alamofire icon indicating copy to clipboard operation
Alamofire copied to clipboard

Published 20 hours ago • verified publisher icon Alamofire

Add WebSocketRequest

Open jshier opened this issue 4 years ago • 2 comments

Goals :soccer:

This PR tracks the addition of WebSocketRequest.

Implementation Details :construction:

TBD

Testing Details :mag:

Tests added.

jshier avatar May 23 '21 00:05 jshier

Awesome to see this 👍 Is this landing anytime soon?

lmcd avatar Jul 20 '21 15:07 lmcd

Thank you 😊

Mkultra555 avatar Apr 02 '22 03:04 Mkultra555

OMG yeah! Push it!

nikolay-kapustin avatar Jul 13 '23 13:07 nikolay-kapustin

@jshier - is there any intent on getting this in at all, or are these commits for your own fork/personal use?

lmcd avatar Nov 19 '23 20:11 lmcd

@lmcd Yes, it's intended to ship publicly. It's just a very large feature I need to get right. I'm about to merge it with the feature under @_spi(WebSocket) as I need to do a bunch of project cleanup and don't have time to write all the documentation I need. Once that's done I can get back to finalizing it with docs.

jshier avatar Nov 19 '23 20:11 jshier

I'm merging this under @_spi(WebSocket) while I work on some project cleanup PRs. That SPI can be used but will be unstable until it's removed. If I need to ship an intermediate version I can, but I intend to get back to finishing up tests and documentation before shipping this feature in general.

jshier avatar Nov 19 '23 21:11 jshier