oss-weather icon indicating copy to clipboard operation
oss-weather copied to clipboard

Map animation is a touch too fast

Open Mrnofish opened this issue 1 year ago • 1 comments

The map animation is a touch fast for my tastes, it makes interpreting the movement of the rain cells harder than it needs be. Would it be possible to perhaps add some way to customize the speed?

Mrnofish avatar Sep 28 '24 13:09 Mrnofish

@Mrnofish sure i ll make it configurable!

farfromrefug avatar Sep 28 '24 16:09 farfromrefug

@Mrnofish it is now implemented

farfromrefug avatar Oct 24 '24 07:10 farfromrefug

Hi, after the Implementation in v2.8.1 the map isn't working any more. Screenshot_20241029_104134_OSS Weather

cb8121 avatar Oct 29 '24 09:10 cb8121

@cb8121 really sorry. Will fix it

farfromrefug avatar Oct 29 '24 12:10 farfromrefug

FWIW it's working for me. There is some room for small improvements (e.g. the slider setting a delay value instead of a speed? thus apparently working the opposite that one would expect) but it's fine otherwise, thanks for taking care of it.

(I'm leaving this open since it's being used to track the regression.)

Mrnofish avatar Oct 30 '24 00:10 Mrnofish

@Mrnofish indeed the animation speed is defined by a delay. Would it be better to have a speed like with default to 1 and the going slower (0.5) or faster (1.5) ?

farfromrefug avatar Oct 30 '24 07:10 farfromrefug

Since the proposed scale would be completely arbitrary (real time not being a useful option), it would come down to the tuning.

What I was pointing out, is that a slider labeled "speed" intuitively associates bigger numbers to higher speeds, whereas now it works in reverse (in fact sliding to the right, which is generally associated with higher/louder/faster/etc, causes the animation to slow down instead.)

I can certainly live with the way it is, though, and simply renaming the slider so that it's consistent with its function would probably be okay for most.

Mrnofish avatar Oct 31 '24 01:10 Mrnofish

@Mrnofish yes i agree it is not ok as it is. I will change it to some arbitrary "speed factor" (1 being the default)

farfromrefug avatar Oct 31 '24 14:10 farfromrefug

Hi, after the Implementation in v2.8.1 the map isn't working any more. Screenshot_20241029_104134_OSS Weather

Hi, even after updating to v2.8.2 I can't see the map. Same Error Message.

cb8121 avatar Nov 13 '24 05:11 cb8121

@cb8121 I am.sorry I can't see what s happening. Was it working before ? Where did you install it from ? Maybe you could share a logcat?

farfromrefug avatar Nov 13 '24 06:11 farfromrefug

Yes, it was working prior to v1.8.1 Unfortunately I have no idea how to provide a logcat. I always used the play store version but with your question in mind I just tested the APK from GitHub and see: the map is working with this version! Nevertheless, would be nice to have the play store version working (again).

cb8121 avatar Nov 13 '24 08:11 cb8121

Yes, it was working prior to v1.8.1 Unfortunately I have no idea how to provide a logcat. I always used the play store version but with your question in mind I just tested the APK from GitHub and see: the map is working with this version! Nevertheless, would be nice to have the play store version working (again).

Interesting! will try to play store build and report to you

farfromrefug avatar Nov 13 '24 09:11 farfromrefug

@cb8121 i found the issue will fix!

farfromrefug avatar Dec 06 '24 13:12 farfromrefug

Map/not found issue seems to be resolved now in both the latest (build 144) Google Play Store and the Github versions.

0-5-0 avatar Dec 07 '24 21:12 0-5-0