Adam Eisenreich

Results 125 comments of Adam Eisenreich

Not much... you have to write the SQL manually

> An additional con is that if they're passing a non-iterable _right now_ it's almost certainly a bug, but this would mask it. > > For example: `Promise.all(getA(), getB(), getC())`...

> I don't use an IDE, and neither does _every_ developer. That's why there is *Pretty much every* and not *every*... What do you use, then? (I am curious) >...

Technically you could create an object with an iterator like so: ``` const obj = { [Symbol.iterator]: function* () { yield 1; yield 2; yield 3; }, }; await Promise.all(obj)...

Since the array has `-readonly` I would assume this one would too. But yeah this overload is simple and correct.

`Promise.all` and `Promise.allSttled` should return the container as resolved from the `Symbol.Iterator` or enumerable keys of given object (in this order). `Promise.race` and `Promise.any` should accept iterable and object but...

> To pass an object to `Promise.{race, any}` could still be done as `Promise.race(Object.values(obj))`. True the benefit added by overload of `Promise.{race, any}` is minimal. Let's not mess with more...

@Harpush Why did you change `SplitArea` from `Directive` to a `Component`? For me, this is a breaking change, and I don't see why it was done. It does break CSS...

Updating to version 4 and above would fix this #624 and possibly also this #824 (Note that 824 is not complete, but a stale bot forced it to be completed...

You could use this in the meantime https://github.com/intbot/ng2-pdfjs-viewer