quit key binding not shown

[Akuli]

<ThePhilgrim2> I can quit, but there is no key binding for it
<ThePhilgrim2> or actually
<ThePhilgrim2> there is, but it's not shown
<Akuli> it should quit with cmd+q, just close all tabs first
<ThePhilgrim2> cmd Q works, but it doesn't show the binding like the others do
<Akuli> ok so that's weird :D

[Akuli]

I wonder if this still happens, after merging #297

[Akuli]

@1anakin20 Can you check whether this works too? :D

[1anakin20]

I'll take a look

[1anakin20]

It quits fine with cmd+q. I am unsure what you mean by quit keybinding is not shown. It is shown on the menu bar > Python > Quit python.

[Akuli]

What's in the File menu?

I don't like how Porcupine shows up as Python when running it, but I guess fixing that properly would require making a Mac app (#266), as I haven't defined the "Python" menu anywhere in my code.

[1anakin20]

This is the whole menu bar, and the inside of the file menu

I'll look into changing python to Porcupine in the menu bar. MacOS sets that menu to the name of the app, in this case Python sets it to "Python" by default.

[Akuli]

Somehow the "File" menu isn't in that screenshot. Maybe it went away when you pressed a key to take a screenshot?

[1anakin20]

You are right, pressed a wrong key. Here it should be

[Akuli]

So that's the "Quit" key binding that isn't shown, but apparently the menus need more work than just making that key binding visible.

[rdbende]

https://tkdocs.com/tutorial/menus.html -> mac part

I recommend to also implement these tk::mac:: functions, it shouldn't use tk's default help, and preferences dialog