laravel-beyond icon indicating copy to clipboard operation
laravel-beyond copied to clipboard

v7.0.0-beta.x feedback

Open regnerisch opened this issue 2 years ago • 10 comments

  • [x] Missing beyond:make:migration command
  • [x] The given module "Auth}" does not exists. Did you run php artisan beyond:make:module Auth?
  • [x] Module can not be --force overwritten
  • [x] #94
  • [x] Illuminate\Contracts\Validation\Rule; is deprecated use Illuminate\Contracts\Validation\ValidationRule;

regnerisch avatar Apr 23 '23 10:04 regnerisch

  • [x] Set --minimal as default on beyond:make:module
  • [x] Fix missing space on info: Action[modules/User/Domain/Actions/UserDestroyAction.php] created successfully.
  • [x] Add autoregister for module service providers
  • [x] Add alias command for beyond:make:dto -> beyond:make:data

regnerisch avatar Aug 03 '23 06:08 regnerisch

  • [x] Set --minimal as default on beyond:make:module
  • [x] Fix missing space on info: Action[modules/User/Domain/Actions/UserDestroyAction.php] created successfully.
  • [ ] Add autoregister for module service providers
  • [x] Add alias command for beyond:make:dto -> beyond:make:data

Why not replace beyond:make:dto by beyond:make:data? Since we are releasing a major version anyways and it's not breaking any existing code only how a Data Object would be created.

alexanderkroneis avatar Aug 03 '23 14:08 alexanderkroneis

I replaced the default beyond:make:dto with beyond:make:data but added an alias beyond:make:dto. See https://github.com/AkrilliA/laravel-beyond/blob/84b4da223a555092a5ff550b8e9a910ee6a1c08d/src/Commands/MakeDataTransferObjectCommand.php#L12

With aliases we could also create short aliases for beyond: commands, e.g. b:m:model

regnerisch avatar Aug 03 '23 14:08 regnerisch

🫡 Good job man.

alexanderkroneis avatar Aug 03 '23 15:08 alexanderkroneis

  • [x] Missing return type array in resource.stub

regnerisch avatar Aug 04 '23 07:08 regnerisch

Some issues I had:

  1. The beyond:make:module is missing in the docs and the --full option does not explain what it does.
  2. It would be nice to automatically place a .gitkeep folder in each directory when generating a module via --full as it would not be tracked in version control otherwise.
  3. Missing test generation commands

Wulfheart avatar Aug 31 '23 08:08 Wulfheart

  1. --full creates all possible directories. (Yes docs should be provided)
  2. We should discuss this, as i prefer removing empty directories from my version control.
  3. As always: Feel free to add the command :)

regnerisch avatar Sep 01 '23 08:09 regnerisch

  • [x] Add MakeTestCommand

regnerisch avatar Nov 30 '23 09:11 regnerisch

@Wulfheart, Test generation is now supported: php artisan beyond:make:test User.UserTest

regnerisch avatar Nov 30 '23 12:11 regnerisch

  • [ ] Command for Scopes
  • [x] Migrate to Laravel Prompts

alexanderkroneis avatar Dec 01 '23 11:12 alexanderkroneis

Closed as we again changed how v7 will work. We try to release v7 next month.

regnerisch avatar May 25 '24 08:05 regnerisch