Pavel Marek

Results 37 issues of Pavel Marek

The `@Builtin_Method` are _"different"_ to regular methods. Originally we wanted to make them behave the same as regular methods, but there is other solution: **hide builtin methods**! Let's restrict usage...

p-low
-compiler

## Current solution (bad) The current website with plots of all the benchmarks is a static website generated from a Jinja template by [website_regen.py script](https://github.com/enso-org/enso/blob/develop/tools/performance/engine-benchmarks/website_regen.py) hosted with GitHub pages on...

-tooling
p-medium

We have two main JAR archives in our distribution - `runner.jar` and `runtime.jar`. Let's add an automated test that will reveal any class duplication that is not allowed. Classes from...

-compiler

Closes #9236 ### Pull Request Description Vast majority of CPU time in ExportsResolution is spent in [BindingsMap.SymbolRestriction.optimize](https://github.com/enso-org/enso/blob/9a373572470ed434fb7b99114553c411ad54718e/engine/runtime-compiler/src/main/scala/org/enso/compiler/phase/ExportsResolution.scala#L173). Let's try to remove this method call and see if all the tests...

CI: No changelog needed
CI: Clean build required

## Current suboptimal module architecture `runner.jar` is currently a fat plain jar (no a JPMS module) located in `built-distribution/component/runner/runner.jar`. System module-path is set to `built-distribution/component`. `runner.jar` contains all the classes...

d-unknown
-compiler

Closes #10157 ### Pull Request Description ### Important Notes ### Checklist Please ensure that the following checklist has been satisfied before submitting the PR: - [ ] The documentation has...

CI: No changelog needed
CI: Clean build required

In https://github.com/enso-org/enso/actions/runs/10533928803/job/29190752771, all the benchmarks fail and yet the whole job succeeded. We should ensure that the whole job exits with non-zero exit code if one of the benchmarks failed,...

-tooling
--bug
-compiler

Follow-up of https://github.com/enso-org/enso/pull/10837 and #10729, part of #10833. https://github.com/enso-org/enso/blob/396d70ddc0184473d42146a440b23226221f1f3e/engine/runtime/src/main/java/org/enso/interpreter/node/EnsoRootNode.java#L65-L74 still uses `LocalScope.scope().allDefinitions()` that forces deserialization of alias analysis metadata for every `EnsoRootNode` created, that is created for at least every...

-compiler
--low-performance

https://enso-org.github.io/engine-benchmark-results/engine-benchs.html#org_enso_compiler_benchmarks_module_ManyNestedBlocksBenchmark_manyNestedBlocks ![image](https://github.com/user-attachments/assets/6beff52d-d484-4fad-9610-a9bfaa85a520) There is a 2x slowdown in the range: https://github.com/enso-org/enso/compare/e836373d9b8989ec3fd565c1536206906867249f...2dbdcb29a13e085cc31f61d61a84916abba4522c The most probable culprit is https://github.com/enso-org/enso/commit/53e99809e2452be46d59c1e313a8d82fbd81f656

-compiler
--low-performance
--regression

There are some big regressions in `*...Map_Id_All_Errors` benchmarks. In some cases, even 500%. Screenshots: ![image](https://github.com/user-attachments/assets/ba969751-c944-4505-850b-2a205a00753b) ![image](https://github.com/user-attachments/assets/45ae73c9-c158-440d-bf3f-27189e4541a7) ![image](https://github.com/user-attachments/assets/a6a1493d-eb02-4606-8a57-6ec5d10ad569) https://enso-org.github.io/engine-benchmark-results/stdlib-benchs.html#org_enso_benchmarks_generated_Map_Error_Benchmark_Vector_ignore_Map_Id_All_Errors ------------------- - Good commit: https://github.com/enso-org/enso/commit/f31c084f43c33e0d988d1bf2f02d5c93bd1f5db9 - Bad commit: https://github.com/enso-org/enso/commit/f0e9616d39d4fc24c8074bd4681fed182d0ede00 - Range: https://github.com/enso-org/enso/compare/f31c084f43c33e0d988d1bf2f02d5c93bd1f5db9...f0e9616d39d4fc24c8074bd4681fed182d0ede00

p-high
-compiler
-libs
--low-performance
--regression