Akarin icon indicating copy to clipboard operation
Akarin copied to clipboard

Published 20 hours ago • verified publisher icon Akarin-project

[1.12.2] Migrate to patch based system

Open ghost opened this issue 3 years ago • 9 comments

For better code organization and compatibility, migrating mixin to a patch based system should be a good try. I'm already working on this and it seems to be easy for me.

Things to be merged

  • [x] Bootstrap part
  • [x] Core part
  • [x] CPS part
  • [x] NSC part
  • [x] Optimization part
  • [x] Realtime part

ghost avatar Aug 19 '22 05:08 ghost

When migrating I've found several codes that aren't or may not be good ( or safe ). These parts will be listed below:

  1. bootstrap/DummyEula.java removed eula checking which I think is not ok.
  2. cps/MixinChunkProviderServer.java tried to directly remove a chunk without nulling lastChunkByPos which is defined in Paper 0087-Optimize-Chunk-Access.patch. Is that safe to do so?

ghost avatar Aug 20 '22 03:08 ghost

I am not sure about number 2, but I agree with you on number 1.

Is EULA checking removed in our current codebase? If so, can you readd it?

josephworks avatar Aug 20 '22 04:08 josephworks

Almost done! :) I've readded EULA, too :)

ghost avatar Aug 26 '22 13:08 ghost

There was a merge to master two days ago. Please be sure to apply those changes as you see fit before your PR.

Thank you so much for your work, and let me know if you need anything!

josephworks avatar Aug 30 '22 09:08 josephworks

Well it seems craftbukkit has already included some realtime fixes, for example in EntityItem.java. it's ok to keep them but I think overriding with akarin's code will be better.

ghost avatar Sep 01 '22 10:09 ghost

Seems that akarin's code base is pretty old now, some mixins are actually conflict with recent craftbukkit changes. lol

ghost avatar Sep 01 '22 12:09 ghost

All codes are done :) I'm going to prepare the build system, double-check the patches and do some clean up job :)

ghost avatar Sep 01 '22 13:09 ghost

@josephworks I'm not so familiar with shell so I'm not so clear how to make the ./akarin work. It would be great that if you can help. I've now finished most of the cleanup job, I'll upload the patches soon :)

ghost avatar Sep 28 '22 01:09 ghost

@siyy123 Sorry for the late response. We can definitely look into getting an ./akarin script to work in the future.

josephworks avatar Feb 21 '23 07:02 josephworks