Akarin icon indicating copy to clipboard operation
Akarin copied to clipboard

[1.12.2] JDK 9+ support?

Open ghost opened this issue 3 years ago • 17 comments

When launching akarin-1.12.2-0.4.2 on jdk 9+ (in my case jdk11) the server will crash. latest.log Maybe we could update the mixin to solve the problem?

ghost avatar May 04 '22 13:05 ghost

Why using Java 8 in 1.12.2 tho?

dani31c avatar Jul 21 '22 20:07 dani31c

Most plugins for 1.12.2 wont work with it

dani31c avatar Jul 21 '22 20:07 dani31c

Why using Java 8 in 1.12.2 tho?

Currently akarin uses launchwrapper and mixin 0.7 for code injection which don't support jdk 9+.

ghost avatar Jul 22 '22 07:07 ghost

Why using Java 8 in 1.12.2 tho?

Currently akarin uses launchwrapper and mixin 0.7 for code injection which don't support jdk 9+.

Well, mixin could be updated for 1.12.2, but there is really no point; Most of the plugins won't work past jre/jdk 8, and 1.12.2 itself was designed for jre/jdk 8, so doing that would still be quite unnecesary nowadays, you'll find no benefit on updating mixin for it

dani31c avatar Jul 22 '22 10:07 dani31c

Why using Java 8 in 1.12.2 tho?

Currently akarin uses launchwrapper and mixin 0.7 for code injection which don't support jdk 9+.

Well, mixin could be updated for 1.12.2, but there is really no point; Most of the plugins won't work past jre/jdk 8, and 1.12.2 itself was designed for jre/jdk 8, so doing that would still be quite unnecesary nowadays, you'll find no benefit on updating mixin for it

Supporting jdk 9+ will be backward compatible and you can still run it with jdk 8 if your plugins don't support. Using higher version of jdk will give better gc, jit, and more cpu features. Actually vanilla and paper are both compiled in java 8 but can also run on jdk 9+ and many plugins are in fact designed for both 1.12- and 1.13+, common plugins designed specifically for 1.12 and java8 actually runs fine with latest java.

ghost avatar Jul 22 '22 13:07 ghost

will try to get support for java 9 and up soonish

WesleyVanNeck avatar Jul 22 '22 14:07 WesleyVanNeck

@siyy123 @LegacyGamerHD What is the status on this?

josephworks avatar Feb 21 '23 07:02 josephworks

@siyy123 @LegacyGamerHD What is the status on this?

not much am prety bussy with life

WesleyVanNeck avatar Feb 22 '23 09:02 WesleyVanNeck

Same! No worries!

josephworks avatar Feb 22 '23 09:02 josephworks

@siyy123 @LegacyGamerHD What is the status on this?

busy too. jdk9+ support would be ok if the patch system can work but I do not have time to test :(

ghost avatar Feb 22 '23 13:02 ghost

I tryed launch akarin with mixin 8.3. And it try to load modlauncher bootstarp:"org.spongepowered.asm.service.modlauncher.MixinServiceModLauncherBootstrap". I think it should load "org.spongepowered.asm.service.mojang.MixinServiceLaunchWrapperBootstrap" to work with LegacyLauncher.

FatSaw avatar Feb 25 '23 16:02 FatSaw

I tryed launch akarin with mixin 8.3. And it try to load modlauncher bootstarp:"org.spongepowered.asm.service.modlauncher.MixinServiceModLauncherBootstrap". I think it should load "org.spongepowered.asm.service.mojang.MixinServiceLaunchWrapperBootstrap" to work with LegacyLauncher.

it s not done yet

WesleyVanNeck avatar Feb 25 '23 16:02 WesleyVanNeck

it s not done yet

I know.

I was building mixin 8.3 for tests and found another possible problem. paper-api uses "org.ow2.asm" v6._ , mixin 8.3 uses "org.ow2.asm" v7._ it may have dependency conflict.

FatSaw avatar Feb 26 '23 08:02 FatSaw

LegacyLauncher has issues working with mixin 8+. I suggest replacing it with ignite: https://github.com/vectrix-space/ignite

FatSaw avatar Feb 26 '23 18:02 FatSaw

Experimental version with 8.5 mixin: https://github.com/FatSaw/Akarin/tree/upstream-mixin-EXPERIMENTAL Built with eclipse.

FatSaw avatar Feb 27 '23 15:02 FatSaw

Why not pull request it to us

WesleyVanNeck avatar Feb 28 '23 12:02 WesleyVanNeck

#240 #241

FatSaw avatar Mar 05 '23 13:03 FatSaw