No-Chat-Reports icon indicating copy to clipboard operation
No-Chat-Reports copied to clipboard

Published 20 hours ago • verified publisher icon Aizistral-Studios

Adds ModMenu support for 1.19.2

Open MODKILLER1001 opened this issue 2 years ago • 6 comments

MODKILLER1001 avatar Aug 07 '22 15:08 MODKILLER1001

https://user-images.githubusercontent.com/17520451/183305657-ec2a17f7-a6bc-424b-9925-30c02a32fbc5.mp4

MODKILLER1001 avatar Aug 07 '22 18:08 MODKILLER1001

This seems to be quite based I approve

RickyTheRacc avatar Aug 07 '22 18:08 RickyTheRacc

Added instructions image

MODKILLER1001 avatar Aug 07 '22 19:08 MODKILLER1001

That doesn't look good: image

Please limit the tooltip to around 50 symbols per line.

Aizistral avatar Aug 14 '22 14:08 Aizistral

Will work on it this week when I have some time off work, Thanks for the feedback rather than just closing it as it helps me improve.

MODKILLER1001 avatar Aug 15 '22 17:08 MODKILLER1001

Somehow I closed this, going to make a new PR

MODKILLER1001 avatar Aug 15 '22 17:08 MODKILLER1001

Also, I would like ModMenuIntegration to be relocated into the same package where NoReportsConfig is, and all fields/methods that are exposed in NoReportsConfig for integration with it to be made package-private instead of public.

https://shedaniel.gitbook.io/cloth-config/advanced/modmenu-integration shows it should be separate as each of the examples has its own file.

MODKILLER1001 avatar Aug 16 '22 04:08 MODKILLER1001

...ok that was not what I meant to do image But just in case, @Madis0, know that I appreciate your feedback here.

Aizistral avatar Aug 17 '22 20:08 Aizistral

Tooltip wrapping is done and working.

MODKILLER1001 avatar Aug 17 '22 22:08 MODKILLER1001