s3-connector-for-apache-kafka icon indicating copy to clipboard operation
s3-connector-for-apache-kafka copied to clipboard
verified publisher icon Aiven-Open

Use default or custom provider chain for s3 authentication

Open markallanson opened this issue 1 year ago • 1 comments

This PR replaces https://github.com/Aiven-Open/s3-connector-for-apache-kafka/pull/227 which was originally implemented by @steephengeorge.

Most of the hard work was already done by @steephengeorge and this PR is a duplicate that addresses the last few code review comments left by @jeqo.

@jeqo I'd appreciate it if you could review this PR to ensure you are happy as i'd like to get this wrapped up and in.

The changes I added here were:

  1. Fix the final String.format issue you identified.
  2. Split tests for AWS credential config into their own test class
  3. Add config tests for the default credentials.
  4. Add tests for the new functionality that was added to AwsCredentialProviderFactory (the primary change in the original PR that had no tests)

markallanson avatar Apr 11 '24 13:04 markallanson

@jeqo Any chance you or one of your team could review and verify you are happy with my solutions to the 2 outstanding comments on the previous pull request this one replaces?

markallanson avatar Apr 19 '24 08:04 markallanson