opensearch-connector-for-apache-kafka icon indicating copy to clipboard operation
opensearch-connector-for-apache-kafka copied to clipboard

Published 20 hours ago • verified publisher icon Aiven-Open

Adding AWS SigV4 authentication

Open fabiojmendes opened this issue 8 months ago • 5 comments

This pull request implements the AWS SigV4 as described in #197

fabiojmendes avatar Oct 14 '23 19:10 fabiojmendes

@fabiojmendes I believe we do not intent to bundle vendor specific schemes into the connector but offer the capability to have it packaged / bundled with additional JARs that could be loaded using ServiceLoader mechanism, @willyborankin please correct me if I am wrong here.

reta avatar Nov 07 '23 21:11 reta

I see your point, but perhaps supporting aws out of the box would be worth the trade off.

I believe that using opensearch as an aws service is a very common use case.

fabiojmendes avatar Nov 10 '23 14:11 fabiojmendes

@fabiojmendes I believe we do not intent to bundle vendor specific schemes into the connector but offer the capability to have it packaged / bundled with additional JARs that could be loaded using ServiceLoader mechanism, @willyborankin please correct me if I am wrong here.

@reta TBH I do not see any problems with adding it to the connector. It is a "kinda" connector way. In any case configuration for custom certificates needs to be added as well.

willyborankin avatar Nov 13 '23 12:11 willyborankin

@fabiojmendes I believe we do not intent to bundle vendor specific schemes into the connector but offer the capability to have it packaged / bundled with additional JARs that could be loaded using ServiceLoader mechanism, @willyborankin please correct me if I am wrong here.

@reta TBH I do not see any problems with adding it to the connector. It is a "kinda" connector way. In any case configuration for custom certificates needs to be added as well.

@fabiojmendes. We do want to see you solution.I personally think this is a valuable feature. Since we need to add support SSL configuration it will take sometime. @reta I think we need to add a separate project which will build together with the connector as separate jar/jars with additional auth libs. Wdyt?

willyborankin avatar Nov 27 '23 10:11 willyborankin

Sounds good @willyborankin, do you need any changes from my side at this point?

fabiojmendes avatar Nov 28 '23 16:11 fabiojmendes