myhoard icon indicating copy to clipboard operation
myhoard copied to clipboard

Run OPTIMIZE TABLE when required

Open nicois opened this issue 2 years ago • 3 comments

Due to changes in the underlying mysql version, it may be required to run OPTIMIZE TABLE on tables which have been ALTERed, to prevent cuprruption.

xtrabackup detects this situation and reports which tables are impacted, so myhoard simply needs to carry out this operation.

nicois avatar Nov 24 '22 03:11 nicois

Codecov Report

Base: 76.59% // Head: 76.81% // Increases project coverage by +0.22% :tada:

Coverage data is based on head (195f83e) compared to base (cbd6e9a). Patch coverage: 80.76% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   76.59%   76.81%   +0.22%     
==========================================
  Files          16       16              
  Lines        3905     3930      +25     
  Branches      932      940       +8     
==========================================
+ Hits         2991     3019      +28     
+ Misses        702      688      -14     
- Partials      212      223      +11     
Impacted Files Coverage Δ
myhoard/basebackup_operation.py 89.86% <63.63%> (-2.86%) :arrow_down:
myhoard/util.py 89.44% <93.33%> (+0.13%) :arrow_up:
myhoard/basebackup_restore_operation.py 80.76% <0.00%> (-3.85%) :arrow_down:
myhoard/controller.py 79.07% <0.00%> (-0.21%) :arrow_down:
myhoard/restore_coordinator.py 78.79% <0.00%> (+2.63%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Nov 24 '22 03:11 codecov-commenter

This change originated from INC-348

andygrunwald avatar Nov 24 '22 07:11 andygrunwald

Also, I think that https://github.com/aiven/myhoard/pull/102 should work as well?

alanfranz avatar Nov 24 '22 20:11 alanfranz