WLED icon indicating copy to clipboard operation
WLED copied to clipboard
verified publisher icon Aircoookie

Add Gledopto Series With Ethernet

Open Aogu181 opened this issue 3 months ago • 2 comments

This submission is to support configurations for the GLEDOPTO Ethernet series, currently supporting models GL-C-616WL and GL-C-618WL. Relevant product information is as follows:

GL-C-616WL: https://gledopto.com/h-pd-86.html GL-C-618WL: https://gledopto.com/h-pd-64.html

Summary by CodeRabbit

  • New Features
    • Added support for Gledopto Series Ethernet boards as a selectable network option.
    • Network settings UI updated to include the new Ethernet choice and reflect the expanded list of supported Ethernet board types (14 total).

✏️ Tip: You can customize this high-level summary in your review settings.

Aogu181 avatar Dec 04 '25 00:12 Aogu181

Walkthrough

Adds one new Ethernet board type "Gledopto Series With Ethernet": a new constant, a new WiFi settings option, and a new ethernetBoards entry with specific GPIO mappings.

Changes

Cohort / File(s) Summary
Gledopto Ethernet Board Support
wled00/const.h, wled00/data/settings_wifi.htm, wled00/network.cpp		 Added WLED_ETH_GLEDOPTO = 13 to const.h; added <option value="13">Gledopto Series With Ethernet</option> to settings_wifi.htm; appended a new ethernetBoards entry in network.cpp with eth_address=1, eth_power=5, eth_mdc=23, eth_mdio=33, eth_type=LAN8720, eth_clk_mode=ETH_CLOCK_GPIO0_IN.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Review attention: verify GPIO pin assignments, ensure eth_type and eth_clk_mode are correct for the hardware, and confirm the UI option value matches the new constant.

Suggested reviewers

  • netmindz

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the main change: adding support for Gledopto Series With Ethernet devices.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f2a35024452596d868739eb1efe057837ae2667e and 4b0cf874c9898f086a3fc70998413b104e33c940.

📒 Files selected for processing (1)
  • wled00/data/settings_wifi.htm (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
wled00/data/**/*.{htm,html,css,js}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use tabs for indentation in web files (.htm/.html/.css/.js) under wled00/data

Files:

  • wled00/data/settings_wifi.htm
wled00/data/**

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

wled00/data/**: When modifying web UI files, run npm run build to regenerate embedded headers before any firmware build For web UI changes, edit files only under wled00/data (not firmware or generated files)

Files:

  • wled00/data/settings_wifi.htm
wled00/data/settings*.htm

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Name settings pages as settings*.htm within the web UI

Files:

  • wled00/data/settings_wifi.htm
🧠 Learnings (11)
📓 Common learnings 
Learnt from: DedeHai
Repo: wled/WLED PR: 4798
File: wled00/FX.cpp:7531-7533
Timestamp: 2025-08-26T11:51:21.817Z
Learning: In WLED PR #4798, DedeHai confirmed that certain gamma-related calls in FX.cpp/FX_fcn.cpp/particle systems are intentional for effect-level shaping (e.g., brightness curves, TV sim, Pride 2015 pre-mix), distinct from final output gamma. Do not flag or remove these in future reviews; add comments when feasible to clarify intent.
📚 Learning: 2025-10-05T15:24:05.545Z 
Learnt from: CR
Repo: wled/WLED PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-10-05T15:24:05.545Z
Learning: Applies to wled00/html_*.h : DO NOT edit generated embedded web header files (wled00/html_*.h)

Applied to files:

  • wled00/data/settings_wifi.htm
📚 Learning: 2025-10-05T15:24:05.545Z 
Learnt from: CR
Repo: wled/WLED PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-10-05T15:24:05.545Z
Learning: Applies to wled00/data/** : For web UI changes, edit files only under wled00/data (not firmware or generated files)

Applied to files:

  • wled00/data/settings_wifi.htm
📚 Learning: 2025-10-05T15:24:05.545Z 
Learnt from: CR
Repo: wled/WLED PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-10-05T15:24:05.545Z
Learning: Applies to wled00/data/settings*.htm : Name settings pages as settings*.htm within the web UI

Applied to files:

  • wled00/data/settings_wifi.htm
📚 Learning: 2025-10-05T15:24:05.545Z 
Learnt from: CR
Repo: wled/WLED PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-10-05T15:24:05.545Z
Learning: Applies to wled00/data/**/*.{htm,html,css,js} : Use tabs for indentation in web files (.htm/.html/.css/.js) under wled00/data

Applied to files:

  • wled00/data/settings_wifi.htm
📚 Learning: 2025-10-05T15:24:05.545Z 
Learnt from: CR
Repo: wled/WLED PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-10-05T15:24:05.545Z
Learning: Applies to wled00/data/** : When modifying web UI files, run `npm run build` to regenerate embedded headers before any firmware build

Applied to files:

  • wled00/data/settings_wifi.htm
📚 Learning: 2025-10-05T15:24:05.545Z 
Learnt from: CR
Repo: wled/WLED PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-10-05T15:24:05.545Z
Learning: Applies to wled00/**/!(html_*)*.h : Use 2-space indentation for non-generated C++ header files (.h)

Applied to files:

  • wled00/data/settings_wifi.htm
📚 Learning: 2025-11-14T13:37:11.994Z 
Learnt from: softhack007
Repo: wled/WLED PR: 0
File: :0-0
Timestamp: 2025-11-14T13:37:11.994Z
Learning: In WLED code reviews, when code is modified or added, look for "magic numbers" (hardcoded numeric literals) and suggest replacing them with appropriate defined constants when those constants are meaningful in the context of the PR. For example, the hardcoded value 32 should be replaced with WLED_MAX_SEGNAME_LEN when it represents a segment name length limit. This improves code maintainability and reduces the risk of inconsistencies.

Applied to files:

  • wled00/data/settings_wifi.htm
📚 Learning: 2025-10-05T15:24:05.545Z 
Learnt from: CR
Repo: wled/WLED PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-10-05T15:24:05.545Z
Learning: Applies to wled00/**/*.cpp : Use 2-space indentation for C++ source files (.cpp)

Applied to files:

  • wled00/data/settings_wifi.htm
📚 Learning: 2025-11-14T13:37:30.955Z 
Learnt from: softhack007
Repo: wled/WLED PR: 0
File: :0-0
Timestamp: 2025-11-14T13:37:30.955Z
Learning: In WLED code reviews, when code is modified or added, look for "magic numbers" (hardcoded numeric literals) and suggest replacing them with defined constants when meaningful constants exist in the codebase. For example, suggest replacing hardcoded "32" with WLED_MAX_SEGNAME_LEN if the context relates to segment name length limits.

Applied to files:

  • wled00/data/settings_wifi.htm
📚 Learning: 2025-08-28T08:09:20.630Z 
Learnt from: mval-sg
Repo: wled/WLED PR: 4876
File: wled00/xml.cpp:0-0
Timestamp: 2025-08-28T08:09:20.630Z
Learning: The WLED codebase has opportunities for refactoring hardcoded array bounds (like the "15" used for DMX channels) to use sizeof(array)/sizeof(array[0]) for more maintainable code, but such changes should be done consistently across the entire codebase in a dedicated refactoring effort.

Applied to files:

  • wled00/data/settings_wifi.htm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 04 '25 00:12 coderabbitai[bot]

Will this eventually be integrated?

TakissX avatar Dec 07 '25 00:12 TakissX

We should also cherry-pick into 0_15_x after merge

netmindz avatar Dec 12 '25 08:12 netmindz

We should also cherry-pick into 0_15_x after merge

Okay, thank you

Aogu181 avatar Dec 12 '25 09:12 Aogu181

@Aogu181 I'm guessing the builds you ship with your products are from 0.15 ?

netmindz avatar Dec 13 '25 12:12 netmindz

@Aogu181 I'm guessing the builds you ship with your products are from 0.15 ?

Yes, this product has been shipped since version v0.15.1.

Aogu181 avatar Dec 13 '25 13:12 Aogu181