Aircoookie
Missing effect
What happened?
Hi. I found out the in the newest 16.xx nightly the effect Fire 2012 is missing. Any chance to integrate this effect in the nightly build?
To Reproduce Bug
I upgraded m devices wemos and esp devices. All if them had presets saved with fire 2012 effects after upgrade from 15.1 to 16 nighty the presets are showing In the color blue. Under effect selection, the effect is missing completely
Expected Behavior
I Integration of this effect in newest nightly. Or is there a way to copy Effects from precious buildy to newer versions. Any help is highly appreciated
Install Method
Binary from WLED.me
What version of WLED?
0.16 nightly
Which microcontroller/board are you seeing the problem on?
ESP32
Relevant log/trace output
Anything else?
No response
Code of Conduct
- [x] I agree to follow this project's Code of Conduct
its replaced by "PS Fire", if you want the old fire effect, compile using "-D WLED_PS_DONT_REPLACE_FX"
@DedeHai I (amongst other users) are not happy with the replacement as well. If it is a replacement it should replace original effect.
I prefer the old look, but that's personal. If you intended PS Fire to be replacement for old effect (Fire 2012) it has to replace it, that means use replaced effect's ID, not use a new one.
EDIT: Honestly, I do not like any of the replacements.
like I said, they are just replaced to save flash and there is a #define for that and that is why its not a direct replacement of ID. IMHO they all look better and are more vesatile.
replaced to save flash
They are removed. And new effects are added. Fire 2012 is not replaced by anything, it is just removed.
like I said, they are just replaced to save flash and there is a #define for that and that is why its not a direct replacement of ID. IMHO they all look better and are more vesatile.
I think we should discuss in our next meeting what is the most appropriate process for such decision making
While I appreciate there is a build flag to restore, that doesn't help the users that install our official builds
We need a proper process for controversial changes like this
FYI: keeping the originals i.e. WLED_PS_DONT_REPLACE_FX=true uses 8.5k of flash.
I added the "light weight" FX back in #5103
since we currently do have enought flash, we could include all FX still in 0.16 and only remove them once flash size gets critical.