Draft PR to get help with MQTT OTA update issue

[JacobK5]

Making this draft PR so I can get help with an issue I'm running into while trying to add remote OTA updates over mqtt.

I can't show my full codebase, but these should be all the relevant changes for my OTA issue

[blazoncek]

Dear Lord.... 😄

Please undo all irrelevant/formatting changes if you want any advice.

[softhack007]

I agree with @blazoncek - I see lots of styling, but still no clue what your problem is about.

I can't show my full codebase, but these should be all the relevant changes for my OTA issue

If you can't show your codebase (closed source) then we need to know at least if this PR provides a feature that will be useful in open source WLED?

[JacobK5]

Dear Lord.... 😄

Please undo all irrelevant/formatting changes if you want any advice.

Yeah my bad, didn't think that through at all, that was really dumb. I've now redone the changes but without any of the formatting changes.

[netmindz]

Have you actually managed to get this to run? When I've previously tried something similar I ran into resource issues?

[JacobK5]

Have you actually managed to get this to run? When I've previously tried something similar I ran into resource issues?

It runs for me and always freezes after about 100kb are downloaded. The free heap looks good at that point, so to me it looks like there isn't a resource issue and that the issue has to do with the connection being interrupted by some other process, but I could be missing something.

[JacobK5]

Just for the record for anybody seeing this now, this was not originally intended to be an actual pull request for changes to be made to WLED. I was having issues with my closed source project that I used WLED for and asked for help in the forums, and was asked to make a draft PR here so they could see my code. That being said, adding remote OTA updates over MQTT likely would be a useful addition to WLED.

[blazoncek]

this was not originally intended to be an actual pull request for changes to be made to WLED

FYI getting help for a closed source project form open source developers requires some sacrifice. PR is a minimum that you can provide as a way of "thank you". Even if it is not merged in the end. It is contribution to knowledge and ideas that count.

[netmindz]

Have you actually managed to get this to run? When I've previously tried something similar I ran into resource issues?

It runs for me and always freezes after about 100kb are downloaded. The free heap looks good at that point, so to me it looks like there isn't a resource issue and that the issue has to do with the connection being interrupted by some other process, but I could be missing something.

I'm not sure I would call "freezes after about 100kb are downloaded" as running successfully 😉

[github-actions[bot]]

Hey! This pull request has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs. Thank you for contributing to WLED! ❤️