WLED icon indicating copy to clipboard operation
WLED copied to clipboard

Fetch supported LED config from Bus

Open netmindz opened this issue 1 year ago • 3 comments

Following on from this PR https://github.com/Aircoookie/WLED/pull/4056

Replace convoluted logic in settings_leds.htm with config requirements supplied in the LEDType data

Motivation - https://github.com/Aircoookie/WLED/pull/3777

netmindz avatar Jul 15 '24 19:07 netmindz

@netmindz please take a look at https://github.com/Aircoookie/WLED/commit/6f3267aee98095bab3381956fa1949f5c09cb2db Implements similar as this PR but does not change Bus class. Instead it utilises BusManager and uses LED type convention to select appropriate GPIO text.

EDIT: There are other (mostly) irrelevant changes throughout bus_manager files to improve readability and optimise code.

blazoncek avatar Aug 22 '24 15:08 blazoncek

Except for GPIO field names I think this PR has become obsolete. Will you expand on GPIO or move that into HUB75 PR? I would prefer latter.

blazoncek avatar Sep 15 '24 11:09 blazoncek

I'll still like to remove things like IP address from the html, but certainly anything in here needs to be redone against the final bus-config

netmindz avatar Sep 15 '24 19:09 netmindz