WLED icon indicating copy to clipboard operation
WLED copied to clipboard

Usermod Battery 🔋 Added Support for different battery types, Optimized file structure

Open itCarl opened this issue 3 years ago • 3 comments

Currently adding new features / restructurings Things. The main purpose for this PR is so that can @softhack007 can see what i already made.

itCarl avatar Jan 05 '23 19:01 itCarl

Hey! This issue has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs. Thank you for using WLED!

stale[bot] avatar Jun 18 '23 07:06 stale[bot]

Hello there, since I finished my studies in university (since the beginning of the year) and now work full time in the healthcare software development area I hardly find time to bring 'private' projects forward. I hope you have a little patience until I find time to finish this PR.

Greetings from Germany ❤️

itCarl avatar Jul 14 '23 19:07 itCarl

Hi 👋, I need some help / suggestions on the current structure of this usermod. I don't know if I still like the "one class for each battery type" approach. My original thought was to make it more flexible and open to a wider variety of battery types by using a module like structure.

itCarl avatar Jan 31 '24 21:01 itCarl

Please rebase for 0_15 branch 1st.

blazoncek avatar Apr 30 '24 13:04 blazoncek

Could you change classes Lion, Lipo and Unknown to something related to battery usermod, like LionBattery for example. This will prevent eventual future conflicts.

Since I do not own any battery powered device and cannot test I'll trust you have done extensive testing... 😄

blazoncek avatar May 03 '24 13:05 blazoncek

Thank you. Is it now ready for merge?

blazoncek avatar May 06 '24 18:05 blazoncek

yes, it is now ready for merging.

itCarl avatar May 06 '24 18:05 itCarl