Usermod Battery 🔋 Added Support for different battery types, Optimized file structure
Currently adding new features / restructurings Things. The main purpose for this PR is so that can @softhack007 can see what i already made.
Hey! This issue has been open for quite some time without any new comments now. It will be closed automatically in a week if no further activity occurs. Thank you for using WLED!
Hello there, since I finished my studies in university (since the beginning of the year) and now work full time in the healthcare software development area I hardly find time to bring 'private' projects forward. I hope you have a little patience until I find time to finish this PR.
Greetings from Germany ❤️
Hi 👋, I need some help / suggestions on the current structure of this usermod. I don't know if I still like the "one class for each battery type" approach. My original thought was to make it more flexible and open to a wider variety of battery types by using a module like structure.
Please rebase for 0_15 branch 1st.
Could you change classes Lion, Lipo and Unknown to something related to battery usermod, like LionBattery for example.
This will prevent eventual future conflicts.
Since I do not own any battery powered device and cannot test I'll trust you have done extensive testing... 😄
Thank you. Is it now ready for merge?
yes, it is now ready for merging.