WLED
WLED copied to clipboard
Aircoookie
Clean up UserMod settings: grouping of variables and add preInfo to variables
Small present from the MoonModules team
See https://github.com/MoonModules/WLED/wiki/Merge-history#november-20-2022
Please no 'disapproves' as this is too good ;-)
... and also includes an update to the wemos_shield environment in platform io, to include audio reactive and the alt rotary/4ld implementations
I personally prefer single topic PRs, where only single changeset, not updating other behaviour
I personally prefer single topic PRs, where only single changeset, not updating other behaviour
Agree with that, will do next time ;-)
Added a commit as discussed with @blazoncek to change um settings variable names to init lowercase for the sound reactive usermod (cpp) and add an initCap function in javascript (js) to display all um setting fields and group names initCap.
So PR offered again for approval 🤞
... and add an initCap function in javascript (js) to display all um setting fields and group names initCap.
An interesting approach. 😀 function initCap(s) { may be easier to understand.
I agree with proposed implementation nevertheless. It would be nice if you could also add replacement for - and _ with space.
... and add an initCap function in javascript (js) to display all um setting fields and group names initCap.
An interesting approach. 😀
function initCap(s) {may be easier to understand. I agree with proposed implementation nevertheless. It would be nice if you could also add replacement for-and_with space.
Sorry, result of copying code from google results without looking ;-) Will change it to function Why replace - and _? I do not see um settings names with - or _ in it.
It may be ridiculous what I have seen in plateformio -D USE_ALT_DISPlAY in the code change. I think, there is a mistake with 1 instead L -D USE_ALT_DISPLAY If this is correct, then sorry to disturb
@blazoncek Due to changes in the way of dealing with txt parameters in addInfo the following code should have also changed:
As this is not the way you want it:
Can you swap the parameters in above code and commit this to WLED AC in order to correct this? Or revert back to the initial setup, as calling addInfo like this is not looking intuitive