i3 icon indicating copy to clipboard operation
i3 copied to clipboard

Window title-bars are still rendered when in hidden tab. Visible with transparency.

Open sharnoff opened this issue 5 years ago • 3 comments

Thanks for working on this! I picked up i3 a week or so ago and I've been loving it. I noticed this issue a couple days ago, so I decided I'd submit it.

I'm submitting a…

[x] Bug
[ ] Feature Request
[ ] Documentation Request
[ ] Other (Please describe in detail)

Current Behavior

When creating vertical/horizontal splits within tabbed mode, the title bars of "hidden" windows are still visible, even though the contents are not. (See screenshots)

Possibly the same underlying cause as Issue #44.

Expected Behavior

Unfocused tabs should be completely hidden, except for the system bar at the top displaying which tab is focused in the layout.

Reproduction Instructions

This layout (or anything similar):

Screenshot from 2020-01-28 17-43-17 Screenshot from 2020-01-28 17-43-22

The title bar for one of the inner windows is visible behind the transparency, even though the rest of the terminal is not. There are more cases of it in the image (like the top bar) but that's the most visible. It's not specific to this layout, however. I've noticed this bug with any combination that involves multiple windows inside a single tab.

I have intentionally increased the transparency to make this effect more easily visible at a first glance. Something else to note is that the difference in highlighting from windows being focused vs. unfocused is also visible. (See the left vs. right side of the line going across the background)

Environment

Output of i3 --moreversion 2>&-:

Binary i3 version:  4.17.1 (2019-08-30) © 2009 Michael Stapelberg and contributors
Running i3 version: 4.17.1 (2019-08-30) (pid 1320)abort…)
Loaded i3 config: /home/max/.config/i3/config (Last modified: Sun 26 Jan 2020 09:28:57 AM GMT, 201245 seconds ago)

The i3 binary you just called: /usr/bin/i3
The i3 binary you are running: i3

This issue occurs with the default config, running picom (compton).

- Linux Distribution & Version: Arch Linux 5.4.15-arch1-1
- Are you using a compositor: Yes, picom (compton).

Final note

If it's not too complicated, I'd love to help out with solving this - just let me know whereabouts I should be looking.

sharnoff avatar Jan 28 '20 17:01 sharnoff

The root cause here is how i3 draws window decorations, which is on the parent container and not the window itself. I'm tentatively open to fixing this, but if possible I'd prefer fixing this as a performance improvement in upstream i3. The code you're looking for is in x.c, and possibly src/render.c

Off the top of my head I'm not sure how easy this is to fix. There also a slim chance this is fixed by https://github.com/i3/i3/pull/4280, though I'd guess that it isn't.

Airblader avatar Dec 31 '20 08:12 Airblader

any update on this?

AndreiSva avatar Jan 20 '21 20:01 AndreiSva

I think this pr maybe helpful here. https://github.com/i3/i3/pull/2665

ChaosEternal avatar Aug 30 '21 07:08 ChaosEternal

I'm closing this issue has i3-gaps is being migrated into i3. If this issue still applies, please reopen it in i3.

Airblader avatar Nov 06 '22 20:11 Airblader