Ingo Bürk

Results 257 comments of Ingo Bürk

This doesn't really solve type safety for the general ng-template case I mentioned. The context variables (let) are typed any and that will always type check when passed to the...

@Lonli-Lokli Yeah, there is https://github.com/angular/angular/issues/28731

I am observing something similar, where alacritty first opens very big and then immediately resizes itself. This is problematic, however, and it should set its correct size *before* mapping the...

I think this can be supported in a non-breaking way with the proposal above. Angular Material has a mat-menu which supports both the current API of ng-zorro as well as...

That's exactly what I'm saying. Except that a warning might not be visible enough. I think this should just fail since tables without entries are meaningless.

Thanks, @onsi! I'd probably argue that the case you're describing is even more reason to fail in this case. 😄 There's always `XDescribeTable` to temporarily disable the test, too. Perhaps...

@MonsterChenzhuo Can you please also rebase to the current master? We merged the addition of `flink-architecture-tests` and it'd be good to add this connector to its dependencies so the rules...

> What do I need to do? Do I close the current pr and pull the master branch for a new commit? No need to close the PR, you can...

No, this doesn't look correct. It looks like you either merged or rebased against the wrong branch.

@maxhbr I cannot rebase-merge this due to > Base branch requires signed commits. Rebase merges cannot be automatically signed by GitHub But I also cannot choose other merge options (or...