Ingo Bürk

Results 257 comments of Ingo Bürk

As a side note, in the documentation we should prioritize & encourage the use of `value$` and discourage that of `valueChanges`.

https://github.com/MrWolfZ/ngrx-forms/tree/master/src/view-adapter also implements custom accessors and is a good reference, though we mostly align with angular's implementation.

At the moment, yes, though of course this can be implemented outside of ngqp as well. I would think for the most part and implementation like Angular's can be more...

A workaround is also to use a regular FormControl for the radio and manually wire it up with ngqp.

Oh, also note this only affects "vanilla" HTML radio buttons. If you're using some component library like Material, it'll already have a ControlValueAccessor and should work fine.

It would also be good to check if this issue can be reproduced with Angular Forms.

Thanks for opening this issue. I'm currently recovering from an illness and on vacation, so unfortunately I can't look into this in detail quite yet, but I will definitely do...

Sorry for the late reply – my illness took longer than anticipated and this fell off my radar. I was just reminded of this in #180, and here's a prototype...

I haven't worked with ngrx router yet so unfortunately no, there's no progress. I still think the idea of using a custom router adapter in ngqp might work*, and is...

If implemented, we should explicitly define & document whether we react on first emission or completion of the returned observable.