realtps icon indicating copy to clipboard operation
realtps copied to clipboard

Panic in esplora client

Open brson opened this issue 3 years ago • 2 comments

thread 'main' panicked at 'u64: ParseIntError { kind: InvalidDigit }', src/realtps_import/src/clients/esplora.rs:51:41

This crashed the entire import process. Need to handle panics better: https://github.com/Aimeedeer/realtps/issues/65

I'm disabling bitcoin for now.

brson avatar Nov 26 '22 20:11 brson

    async fn get_latest_block_number(&self) -> Result<u64> {
        let block_number = reqwest::get(format!("{}/{}", self.url, "blocks/tip/height"))
            .await?
            .text()
            .await?;

        Ok(u64::from_str(&block_number).expect("u64"))
    }

This code should error if the block can't parse.

brson avatar Nov 26 '22 20:11 brson

In general it looks like we never check that status of HTTP reqwest responses: https://github.com/Aimeedeer/realtps/issues/72

brson avatar Nov 26 '22 20:11 brson