aider icon indicating copy to clipboard operation
aider copied to clipboard

feat: customizable timeout duration

Open mario7421 opened this issue 1 year ago • 1 comments

When using local LLMs can be useful to set a custom timeout for litellm HTTP calls to the model. The default being 10 minutes.

mario7421 avatar Sep 16 '24 10:09 mario7421

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=44199812 --os-family=ubuntu

Note: This applies to commit 310b3b73

pr-commenter[bot] avatar Sep 06 '24 18:09 pr-commenter[bot]

Regression Detector

Regression Detector Results

Run ID: 38869366-4efa-48ed-8660-e4980b6a8715 Metrics dashboard Target profiles

Baseline: 897e31f7577e89a0afc9b6b85ac6670d5b63cfcd Comparison: c7aa4320d4d9bd41fdbb9442ccbbab9f34f1935d

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +5.74 [-7.17, +18.65] 1 Logs
pycheck_lots_of_tags % cpu utilization +0.70 [-1.79, +3.20] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.00, +0.00] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
otel_to_otel_logs ingress throughput -0.08 [-0.89, +0.73] 1 Logs
idle memory utilization -0.14 [-0.17, -0.11] 1 Logs
file_tree memory utilization -0.38 [-0.43, -0.33] 1 Logs
basic_py_check % cpu utilization -0.58 [-3.23, +2.08] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.44 [-2.21, -0.67] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

pr-commenter[bot] avatar Sep 06 '24 19:09 pr-commenter[bot]

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Sep 06 '24 20:09 bits-bot

/merge

derekwbrown avatar Sep 16 '24 15:09 derekwbrown

:steam_locomotive: MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

dd-devflow[bot] avatar Sep 16 '24 15:09 dd-devflow[bot]