ngx-device-detector icon indicating copy to clipboard operation
ngx-device-detector copied to clipboard

Published 20 hours ago • verified publisher icon AhsanAyaz

#269 Brave Browser Detection

Open MattSenter opened this issue 2 years ago • 4 comments

Problem

There is no detection for Brave Browser in this library.

Solution

Add userAgentData inspection to detect Brave Browser. Note that userAgentData can also be used to detect Chrome over the legacy userAgent string.

MattSenter avatar Feb 24 '23 00:02 MattSenter

@MattSenter this is awesome work! Could you check the lint errors and push again? I can review and merge asap then 🙂

AhsanAyaz avatar Mar 09 '23 09:03 AhsanAyaz

@AhsanAyaz Updated! Sorry it took so long.

MattSenter avatar May 10 '23 14:05 MattSenter

@AhsanAyaz fixed conflicts

MattSenter avatar May 25 '23 21:05 MattSenter

@AhsanAyaz I think the workflow might be busted. I'm not seeing a linting or testing issue on my end.

MattSenter avatar Jun 16 '23 14:06 MattSenter