HypeMailchimpBundle icon indicating copy to clipboard operation
HypeMailchimpBundle copied to clipboard

API configs as separate vars

Open TomSchillemans opened this issue 10 years ago • 2 comments

I have seen another MailChimp bundle (only for API v1.3 at the moment) which uses separate variables for defining things like double_optin, send_welcome and things like that rather then like you do now setting those in the parameters of the different functions.

If you don't want this it is ok for me, I just think it is more clear for the user of this bundle and easier to use. But if you do like this, I could look into this this weekend of you want.

TomSchillemans avatar Nov 11 '14 11:11 TomSchillemans

Hey Tom, I guess that's good idea as long as it doesn't break the current implementation, to be used as roleback value

if you can provide snippet how usage will look like after this change

or reference to the other bundle m would be great

AhmedSamy avatar Nov 11 '14 22:11 AhmedSamy

Sure I can do both, the latter one would be easier!

in this bundle, in the readme you can see how I mean it. Good examples are the subscribe and update methods described there.

by rollback you mean that how the methods currently are working, they need to stay working like that?

I should be able to use override methods I do think. Also I am willing to update the readme of this bundle to reflect the changes.

TomSchillemans avatar Nov 12 '14 08:11 TomSchillemans