Aharnish Solanki
Aharnish Solanki
> Thank you for your contribution! > > This PR has a valid DCO and tests. The relevant team for this area will confirm the design of the implementation choices....
Hi @reinsch82, I have rebased the PR and updated the variable names.
Hi @reinsch82, https://github.com/gradle/gradle/pull/33432/commits/850da7f03c15c5c79c6903ebb5455b7d5fb69101 is the commit that renames the variable according to the naming patterns. Was it something different that you meant? Also, will fix the sanity check issues shortly...
Hi @reinsch82 , When I am doing the sanity check in Windows OS, 2 test cases are failing(image attached). I did some research on it and found out it might...
Hi @reinsch82, I have rebased it and cleaned the PR.
Hi @reinsch82, yes, I'm still interested and will complete this, addressing your comments.
Hi @reinsch82 , this PR has been closed and I have opened a new PR https://github.com/gradle/gradle/pull/34975 for this issue #33407
> Thank you for your contribution! > > This PR has a valid DCO and tests. The relevant team for this area will confirm the design of the implementation choices....
Hi @Jolanrensen ! I'm interested in contributing to this issue as a new contributor. ### Proposed Solution I've updated the `createConverter` function to add converters for `LocalTime`: ```kt import kotlinx.datetime.toKotlinLocalTime...
Hi @Jolanrensen, yes I'm up for it ! I'll make the changes and get it reviewed from you. Thank you for giving me this opportunity.