ngx-material-timepicker icon indicating copy to clipboard operation
ngx-material-timepicker copied to clipboard

Validation MIN not working for HOURS ngx-timepicker-field

Open DenSmolonski opened this issue 4 years ago • 8 comments

Hi, validation MIN not working for HOURS ngx-timepicker-field. I set validation in MIN '10:30'. When i put arrow down in ngx-timepicker-field for hour i get error and can change hour. I change hour from 10 to 09. image image

For minutes work all correctly, i can not change to invalid minute. Example from 30 to 29. How can i fix it?

DenSmolonski avatar Jun 11 '20 12:06 DenSmolonski

Add info. MIN not work for 24 format.

DenSmolonski avatar Jun 11 '20 12:06 DenSmolonski

I will check

Agranom avatar Jun 13 '20 10:06 Agranom

Do you fix a problem? I can help and fix it and you check my pull request.

DenSmolonski avatar Jun 24 '20 07:06 DenSmolonski

@DenSmolonski It would appritiate you help, cause I'm a bit run out of time

Agranom avatar Jun 26 '20 06:06 Agranom

@Agranom @DenSmolonski is this fixed?

iluminoguru avatar Aug 11 '20 12:08 iluminoguru

Hi, I have the same problem with the min. And also, I cannot edit the minutes with keyboard entries when there is a min specified in the field.

CSoetaert avatar Aug 13 '20 12:08 CSoetaert

same problem with min and max in 24h format

enzoberger avatar Jul 27 '21 14:07 enzoberger

OK, i guess I found the bug. It in the file "ngx-timepicker-field.component.ts" line 147. Your calling the isChangePeriodDisabled only for 12 hour format. You just need to delete the "if" in line 147 and it will work fine for 24 hour format. That should also solve issue https://github.com/Agranom/ngx-material-timepicker/issues/369 Would be great if you could fix that asap. Thanks! image

enzoberger avatar Jul 28 '21 09:07 enzoberger

Hello, i have same problem, ¿can you solve it asap, please? Thanks :)

anuskazw avatar Jun 08 '23 14:06 anuskazw

The issue is fixed. Pls update to the latest version

Agranom avatar Jun 12 '23 10:06 Agranom