react-native-geolocation-service icon indicating copy to clipboard operation
react-native-geolocation-service copied to clipboard

Namespace in AndroidManifest no longer supported

Open yousrasd opened this issue 6 months ago • 1 comments

Platforms

Android

Versions

Please add the used versions/branches

  • Android: target sdk 34
  • react-native-geolocation-service: 5.3.0
  • react-native: 0.72.10

Description

Getting build error for Android on my CICD pipeline on this lib which is causing my builds to fail.

Error: package="com.agontuk.RNFusedLocation" found in source AndroidManifest.xml: /node_modules/react-native-geolocation-service/android/src/main/AndroidManifest.xml. [20:25:21]: ▸ **Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated.** [20:25:21]: ▸ Please instead set the namespace (or testNamespace) in the module's build.gradle file, as described here:https://developer.android.com/studio/build/configure-app-module#set-namespace`

Seems like using package in AndroidManifest is now deprecated. We should switch to namespace. Ref:

  • https://developer.android.com/studio/build/configure-app-module#set-namespace
  • https://stackoverflow.com/questions/71775818/android-manifest-merge-error-when-removing-package-name-for-namespace

yousrasd avatar Aug 15 '24 20:08 yousrasd