react-native-geolocation-service icon indicating copy to clipboard operation
react-native-geolocation-service copied to clipboard

upgrading to googlePlayServicesVersion 21.0.1

Open trne opened this issue 8 months ago • 2 comments

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-geolocation-service/android/build.gradle b/node_modules/react-native-geolocation-service/android/build.gradle
index cf167cf..47fd5ae 100644
--- a/node_modules/react-native-geolocation-service/android/build.gradle
+++ b/node_modules/react-native-geolocation-service/android/build.gradle
@@ -4,7 +4,7 @@ def DEFAULT_COMPILE_SDK_VERSION          = 29
 def DEFAULT_BUILD_TOOLS_VERSION          = "29.0.2"
 def DEFAULT_MIN_SDK_VERSION              = 16
 def DEFAULT_TARGET_SDK_VERSION           = 29
-def DEFAULT_GOOGLE_PLAY_SERVICES_VERSION = "18.0.0"
+def DEFAULT_GOOGLE_PLAY_SERVICES_VERSION = "21.0.1"
 
 def safeExtGet(prop, fallback) {
   rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback

This issue body was partially generated by patch-package.

trne avatar Nov 06 '23 22:11 trne

Thanks @trne

This resolved an issue I was experiencing on Android for the error (see image) bug

its-acarn avatar Nov 09 '23 11:11 its-acarn

Thank you guys ! I've had this issue and updating the versioning to

playServicesLocationVersion = "21.0.1"

in my build.gradle. It works. Along side with

googlePlayServicesVersion = "18.0.0"

I've also run

npx patch-package react-native-geolocation-service

after modifying

-def DEFAULT_GOOGLE_PLAY_SERVICES_VERSION = "18.0.0"
+def DEFAULT_GOOGLE_PLAY_SERVICES_VERSION = "21.0.1"

in node_modules/react-native-geolocation-service/android/build.gradle

I think there is a related PR waiting to be merged. So this might be fixed in near future i hope

LouisJS avatar Nov 24 '23 10:11 LouisJS