agnosticui icon indicating copy to clipboard operation
agnosticui copied to clipboard

Fixing two-way binding for inputs fixes #237

Open edwinwong opened this issue 2 years ago • 1 comments

Pull Request Template

Description

Set the type attribute for the inputs non-dynamically, and changed the manually two-binding to the Svelte two-way binding using bind:value.

Fixes # 237

I've commented on the issue. This is my first pull request, please let me know how I could improve in the future, thanks!

Checklist:

Please delete options that are not relevant.

  • [✓] Is this a bug fix
  • [ ] Have you submitted new feature or bugfix issue? Unless it's a small bugix, we generally prefer to track PRs against an issue which starts a dialogue to give us context.
  • [ ] Tests passing?
  • [ ] Have you added to the framework's /examples apps? e.g. agnosticui-react/examples? These are kitchen sink sanity checks which help to verify a component is working and derive documentation snippets.
  • [ ] Have you updated the docs? These live in site/docs

edwinwong avatar Mar 25 '23 20:03 edwinwong

Deploy Preview for agnostic-astro canceled.

Name Link
Latest commit ea8a35a378dd2462023cb02049146fef73b999c1
Latest deploy log https://app.netlify.com/sites/agnostic-astro/deploys/641f5f807c6ea200086ae463

netlify[bot] avatar Mar 25 '23 20:03 netlify[bot]