agnosticui icon indicating copy to clipboard operation
agnosticui copied to clipboard

Svelte use of quotes and linting

Open roblevintennis opened this issue 2 years ago • 3 comments

We should have a standard and be consistent within the agnostic-svelte/* package. I don't think any of our configurations is enforcing consistency there.

  • See what the consensus is in the Svelte community and follow UPDATE: Sounds like Croug found the answer:

it seems in the svelte docs they use ' for imports and ` for strings generally

  • Add a linter and formatter that can enforce and fix respectively
  • Backfill and commit fixes

roblevintennis avatar Apr 18 '22 17:04 roblevintennis

@Croug per our conversation in Gitter ☝️

roblevintennis avatar Apr 18 '22 17:04 roblevintennis

Perfect

Croug avatar Apr 18 '22 17:04 Croug

I'm reassigning to @gcsecsey so @Croug can focus on getting the Table / Pagination stuff pulled through. We're getting close to completing the svelte typescript port and I think this should be added to it before we nuke the old agnostic-svelte package and replace it with what's now agnostic-svelte-ts/*

roblevintennis avatar May 15 '22 12:05 roblevintennis