Raghav Aggarwal

Results 97 comments of Raghav Aggarwal

@zabetak , can you please re-review it, if you have the bandwidth

Thanks @zabetak , for the review. your insights are always appreciated. I will address the review comments :-)

@zabetak, have updated the PR, can you please review?

Based on the debugging, the _Task#initialize()_ method creates conf object in HiveServer2-Handler-Pool thread and when the post hook for protologging is triggered, it created a new thread (Hive Hook Proto...

@zabetak, can you please help with the review as the changes are around HIVE-22173's code.

Just info: [HIVE-27240](https://issues.apache.org/jira/browse/HIVE-27240), was very similar to this issue based on stacktrace, which shows the need for UT :-)

Hi @zabetak, apologies for late reply, just wanted to let you know that I'm working on this PR and found some new issues like [HIVE-29053](https://issues.apache.org/jira/browse/HIVE-29053) along the way when coming...

> The end to end approach (2.) seems a bit of an overkill. Even if the NPE is caught and logged you still have some missing entries (e.g., `queryPlan`) in...

Test failure `org.apache.hadoop.hive.metastore.security.TestZookeeperTokenStoreSSLEnabled`, Seems irrelevant to change.

@zabetak , I have addressed the review comments. can you please take a look?