agenta icon indicating copy to clipboard operation
agenta copied to clipboard

[AGE-433] [bug] New exact match and JSON evaluators are created with each served variant

Open mmabrouk opened this issue 1 year ago • 4 comments

To reproduce:

  • Create an app from cli (agenta init)

  • Serve variant 1

  • Create new code (app2.py) and serve variant2

    A new exact match and contains json evaluator will be created: https://share.cleanshot.com/QWVWKpFJ

    CleanShot 2024-07-16 at 16.06.07@2x.png

Correct behavior:

  • Exact match and contains json are only created when the app is initialized and not at each variant serve

From SyncLinear.com | AGE-433

mmabrouk avatar Jul 16 '24 14:07 mmabrouk

Hello Interested in tackling this issue can I get more info

Dozie2001 avatar Jul 26 '24 18:07 Dozie2001

Hi @Dozie2001 ,

It looks like the issue is here. Each time we create a new variant, we call create_ready_to_use_evaluators which creates these evaluators. However this should only be done when we create an app and now when we create a variant. The solution to call create_ready_to_use_evaluators when we create the app and not here and here. So it should happen here, hope this helps.

mmabrouk avatar Jul 26 '24 19:07 mmabrouk

I've assigned it to you @Dozie2001 let me know if that would work.

mmabrouk avatar Jul 26 '24 19:07 mmabrouk

Ok will get to it now

Dozie2001 avatar Jul 26 '24 22:07 Dozie2001

I am closing this now, we will tackle it in a new issue related to the release

mmabrouk avatar Nov 20 '24 10:11 mmabrouk