Age Manning
Age Manning
> If nodes could still join more subnets, as per the current --subscribe-all-subnets flag or similar, it would avoid the situation of a large validating node potentially not subscribed to...
> Instead of having it based on peer-id have it based on node-id (used in discovery can be calculated from ENR and most cases, peer-id). If we base the subnet...
I can write up a simulation at some point, verifying the idea suggested above saves us discovery hops when traversing the DHT comparted to randomly searching. I'll post results here....
I suspect this is related to #3212 also. Once we have implemented a solution to that, I think that may also help.
bors r+
bors r+
Is this ready for review?
Yeah I think we do want this, as long as the default is the usual behaviour. The compile-time flag enables this extra functionality and is handy for further testing
Yeah the changes look fine to me. We only have one inbound substream as you've pointed out, so I dont see any issue here