NLOS-Track icon indicating copy to clipboard operation
NLOS-Track copied to clipboard

Questions related to the yaml file

Open batman47steam opened this issue 2 years ago • 6 comments

The default yaml file seems not work.

batman47steam avatar Jul 12 '23 06:07 batman47steam

Sorry for the deprecated YAML configuration file 😿 Just remove the total_len key and change the noise_factor key to noisy.

As for the problem with model_name, I will merge your PR as a fast solution~ Thanks for your contribution 😄

AgainstEntropy avatar Jul 12 '23 10:07 AgainstEntropy

Hi, thank you for the response and for sharing the code and dataset. I think this work is pretty cool. I found that noise_factor also appeared once in the trainer.py, but it doesn't seem to be used anywhere else. since I haven't read the code thoroughly, I am not sure is that ok to also remove the noise_factor in log_train_cfg ? image

Thanks! 😆 It means a lot to me~

Feel free to modify the log_train_cfg dict since it is just some configuration logged to wandb for experiment tracking.

I will keep this issue open until no more minor mistake is found~

AgainstEntropy avatar Jul 13 '23 02:07 AgainstEntropy

Hi, the email address in the paper seems unable to reach, can you provide another email address. So that I can further consult some details.

Sure! Please contact me (the first author) at [email protected] or [email protected]

Sorry for the invalid email address due to departure from Shanghai AI Lab. If you would like to contact any of the other authors, feel free to send an email at the address shown on the paper, as they are still in Shanghai AI Lab.

AgainstEntropy avatar Jul 20 '23 01:07 AgainstEntropy

In compute_track_metrics functions, all these metrics have been averaged on the sequence length T (pcm / T, area / T, dtw / T). but in the compute_batch_metrics, it seems that the result is not averaged over batch dimensions, it returns the sum of these metrics in a batch. I'm not sure if this is why larger batch sizes lead to higher values for these metrics. I also trained with batch_size = 6, the pcm, area, and dtw metrics is much lower than batch_size = 32 image image

batman47steam avatar Jan 04 '24 07:01 batman47steam

Hi, In the simulation dataset, for example, 944, there are some negative values in video_128.npy and video_128_noisy.npy, was an additional data enhancement operation performed? image

batman47steam avatar Jan 04 '24 07:01 batman47steam